search

Jarada / WuufusWaygates

Spigot Plugin: Wuufu's Waygates is a gate plugin inspired by Creative Gates and Stargate that allows players to connect gates into networks using any material and without any commands
https://www.spigotmc.org/resources/wuufus-waygates.80094/
GNU General Public License v3.0
8 stars 4 forks source link

Feature/configurable recipes #22

Closed kccricket closed 2 months ago

kccricket commented 2 months ago

This PR enables completely configurable crafting recipes and item icon materials. (I wanted to use amethyst shards for my keys.)

I found this comment on your Discord channel where you expressed an opinion that the item material should be limited. As a counter argument, I feel the danger can be managed with appropriate documentation. "Don't pick a dumb item."

I could add a whitelist, though. It would just be tedious to create and maintain.

In retrospect, I probably went too far by refactoring some of the DataManager public class fields into Maps with getters. If desired, I will back out those changes, leaving the configurable recipes.

Jarada commented 2 months ago

Indeed, I did once express that. I believe that was back when I had first released Waygates and was doing everything I could to keep it in a stable location. I think it's pretty stable right now, and I also believe customisation and the ability to make the plugin your own is a great thing. It's why I love what I've made so far, as the plugin really allows for creativity and personalisation.

I think this will be a great addition. I'll review the code and likely this will be merged and included. Thanks for the work you've put in!