JarbasHiveMind / HiveMind-cli

OpenVoiceOS Remote CLI
Apache License 2.0
7 stars 7 forks source link

Update requirements to include needed jarbas-utils module #6

Closed ddubau closed 3 years ago

ddubau commented 3 years ago

Add jarbas-utils module into requirements file to be installed as a dependency as it is required for the cli to run.

ChanceNCounter commented 3 years ago

Thanks for helping with HiveMind!

The reason this missing dep has been sitting there for so long is because jarbas_utils has been deprecated in favor of ovos_utils. I'm very sorry about that. What this repo needs is to migrate.

You're absolutely welcome to do that obnoxious refactor, though =P more of a chore than anything. It might just be a find-and-replace. One of us will get around to it if nobody PRs.

Very, very sorry for the inconvenience! We need to take a trip around our repos for things like this. Since there are so few of us using and testing these repos, stuff like this that Works In The Meantime hasn't been a priority.

Incidentally, deps also need to be reflected in setup.py, although setup.py can be instructed to look at requirements.py so 🤷‍♂️ whatever gets the thing in the place so it can do the stuff.

ChanceNCounter commented 3 years ago

For reference, #4 which I've just updated to reflect its actual nature =P

ddubau commented 3 years ago

@ChanceNCounter Ok but when cloning down this repo(cli) it will not run unless you install jarbas-utils as it throws an error requiring it. I think in order to resolve it being broken you should at least accept that change. Then later if you want to go back and rename/refactor you can.

ddubau commented 3 years ago

@ChanceNCounter I am also new to this project so still trying to figure out how all this works. I think the setup documentation could use some updating possibly.

ChanceNCounter commented 3 years ago

Feels like breaking code to fix code. I want to stress: jarbas_utils as far as we are concerned does not exist anymore.

I'm gonna go in and do the refactor now, because this will probably keep happening, but this isn't the only HiveMind repo with outdated deps. This is one of the reasons we keep stressing that HiveMind is barely even alpha =P 24 hours in a day, small team in our spare time, and we're all working on OVOS as well, having merged dev teams. OVOS is both closer and has a large audience waiting semi-patiently for a build, so HiveMind keeps getting backburnered for a week and then another week and another week.

All of which is to say, stick to this and the Voice Sat for the next few weeks. The wiki probably should have told people to start with the voice sat rather than CLI. Jarbas and I were just talking in chat about the need to go on a dep-fixing rampage as soon as one or both of us can spare the time.

ddubau commented 3 years ago

@ChanceNCounter yeah I can see how it can feel like fixing one issue just to change it again in the near future can be not appealing. I was just trying to help any new people that come along and clone down the cli project won't be able to run it as is unless they install jarvas-utils.

Also is there a discord/slack or some other method we can chat other than here? Maybe I can help with the project once I get a hang for how it's setup? Also want to hear more on what OVOS is.

ChanceNCounter commented 3 years ago

Absolutely I appreciate your intent! Didn't mean to come across otherwise.

We have a chat channel on Mycroft's official Mattermost server at https://chat.mycroft.ai/ (if you recently tried to join but got "user limit exceeded," that's been resolved)

OVOS - OpenVoiceOS - is a community-built smart speaker image, based on buildroot, with the current build targets being Pi4 and the Mycroft Mk2 dev kit. That doesn't have its own channel in chat, but it does have a long-running thread at the Mycroft forum.


7 should fix the dep problem, but at the moment it will only connect with keys (access and crypto)

ChanceNCounter commented 3 years ago

Also, just in case you're curious, in this repo's case, t was actually the outdated version of jarbas_hive_mind that caused the problem. HiveMind-core was migrated a couple versions ago, but it's on 0.10.7 and this repo was on 0.10.1! Oof.