JarbasSkills / skill-sovietwave

sovietwave radio skill
Apache License 2.0
1 stars 1 forks source link

Reliant on ovos-workshop 0.0.3a1 => breaks various other skills of yours #3

Closed theCalcaholic closed 3 years ago

theCalcaholic commented 3 years ago

So, in order to comply to the new requirements.txt, I installed ovos-workshop from master (because 0.0.3a1 is not available on pipy yet).

Unfortunately, this broke some other skills of yours (disregarding the fact that automatic installation won't work):

theCalcaholic commented 3 years ago

As I erroneously assumed that multiple skills were broken, this issue is now basically reduced to the reminder that the requirements aren't all available on pipy at the moment :)

Fee free to close it at any time

JarbasAl commented 3 years ago

essentially every skill in this list needs to be checked and possibly updated to latest imports/pkg versions https://www.pling.com/c/1489798/

please open issues in the individual repos for skills, or https://github.com/OpenVoiceOS/skill-better-playback-control if it affects several skills. I expect most time will be a simple change of imports and requirements.txt, hopefully this was the last time the imports changed and it should be easier to keep things in sync moving forward

JarbasAl commented 3 years ago

So, in order to comply to the new requirements.txt, I installed ovos-workshop from master (because 0.0.3a1 is not available on pipy yet).

published on pipy

theCalcaholic commented 3 years ago

Just to let you know: Issues are disabled on https://github.com/OpenVoiceOS/skill-better-playback-control, otherwise that would have been my first idea as well :)

JarbasAl commented 3 years ago

Just to let you know: Issues are disabled on OpenVoiceOS/skill-better-playback-control, otherwise that would have been my first idea as well :)

oops, that was an oversight, i think they are enabled now, thanks for the ping