JaredScar / Badger-Anticheat

Badger's Official Anticheat [code inspirations from DevLanceGood and Bluethefurry on GitHub]
MIT License
44 stars 29 forks source link

Uninstall option #23

Open Nophobia09 opened 3 years ago

Nophobia09 commented 3 years ago

Once installed this script writes to the manifest of all resources that it is a dependency. After uninstall the scripts are still looking for badger-anticheat because it is still in the manifest to do so. An uninstall bat would be nice to remove client_script "@Badger-Anticheat-master/acloader.lua" in one wack rather than going through each resource and removing it manually.

Something like this.... Which must be ran inside the main resource directory to update all resources. Manifest_Updater.zip

a59ASB commented 3 years ago

Hey i didnt got ur exact issue but i hope this helps DEL <directory> it will delete the program and you can configure it with START command in ur bacth file like START DELETE

Nophobia09 commented 3 years ago

Hey i didnt got ur exact issue but i hope this helps DEL <directory> it will delete the program and you can configure it with START command in ur bacth file like START DELETE

What I mean is in every resource on the server that has a manifest file such as fxmanfiest.lua or __resource.lua (which is every single resource) after installing badger-anticheat contains the line 'client_script "@Badger-Anticheat-master/acloader.lua"'. After you remove badger-anticheat that line 'client_script "@Badger-Anticheat-master/acloader.lua"' is still in every single resource in the server and then shows an error in the console because the resources can't find the dependency badger-anticheat because it's no longer there. But the resources are still searching for badger-anticheat as a dependency because badger-anticheat writes that line to every resources manifest file. Does this help you better understand?

JaredScar commented 2 years ago

Apparently this doesn't even work anymore so it's pointless now. Hopefully someone can remove it all-together in a pull-request in the near future. I'll leave this open until then.

gegelendvay commented 1 year ago

Apparently this doesn't even work anymore so it's pointless now. Hopefully someone can remove it all-together in a pull-request in the near future. I'll leave this open until then.

I couldn't find a way either to remove the added client script from fxmanifest.lua's. Does your decision still stand to remove the whole mod menu check function? If so, I will create a PR to resolve this issue.

JaredScar commented 1 year ago

Apparently this doesn't even work anymore so it's pointless now. Hopefully someone can remove it all-together in a pull-request in the near future. I'll leave this open until then.

I couldn't find a way either to remove the added client script from fxmanifest.lua's. Does your decision still stand to remove the whole mod menu check function? If so, I will create a PR to resolve this issue.

I believe so. FiveM thought it was invasive and I could of sworn they removed the functionality of it from actually doing anything. Someone would need to test it and verify this though