search

JaredScar / Badger_Discord_API

A FiveM API Script [created by Badger]
MIT License
56 stars 48 forks source link

Non discord members are able to join #40

Closed PCL-CrisKolkman closed 1 year ago

PCL-CrisKolkman commented 1 year ago

Hello,

I've been testing out this script and I do like it, but yesterday someone who is not member of the Discord server was able to join my server anyway. Today I tried it out with a test Discord account and I was also able to join the server without being member of the Discord.

When trying to join the screen that you must join Discord first is being shown, which is perfectly fine.

image

But when you click the Play button on above mentioned screen without joining the Discord server, you are allowed in the game anyway and below error is being shown in the server console:

[script:Badger_Discor] [Badger_Perms] ERROR: Code 200 was not reached... Returning false. [Member Data NOT FOUND] DETAILS: Error - The resource at the location specified doesn't exist.
[ script:connectqueue] QUEUE: username[license:***] was placed 1/1 in queue
[ script:connectqueue] QUEUE: username[license:***] is loading into the server
JaredScar commented 1 year ago

How is this even an issue?... This is working as intended

ODOJRP commented 1 year ago

How is this even an issue?... This is working as intended

I agree. I’d rather people still be able to join than be blocked from joining cause they aren’t in the discord.