Jaredk3nt / laserwave

A retro outrun / cyberpunk inspired VS Code theme
https://marketplace.visualstudio.com/items?itemName=jaredkent.laserwave
MIT License
139 stars 20 forks source link

Diff view inserted text is not legible #20

Closed TGiles closed 4 years ago

TGiles commented 4 years ago

The inserted text background is not legible when inserting new code blocks into a file. image

I can whip up a fix for this later today. I think the background just needs to be more transparent, but wanted to open a issue so we could start a discussion

I've been using a transparent maximum blue (#40b4c42d) and it seems to cut through better than pearl aqua image

Jaredk3nt commented 4 years ago

What flow does this come from so I can take a look at it?

TGiles commented 4 years ago

I'm assuming you're asking for steps to reproduce (which I should have included in the first place 😬) Steps to reproduce:

  1. Add a file to git repository
  2. Add a block of code to previously added file, which triggers the Modified (M) tag in the source control tab
  3. View the file in the diff editor
  4. Inserted text is hard to read a majority of the time image

Something else I noticed is that this might be a monitor setting issue as well. I moved the hard to read diff view between my monitors and noticed some legibility changes.

Let me know if you need any more info!

Jaredk3nt commented 4 years ago

Sorry for the delayed response, I also agree it's pretty hard to read. The teal color is meant to be more common in the UI than the blue so I'm a bit hesitant to switch over, but I think toning the opacity down quite a bit is necessary.

TGiles commented 4 years ago

@Jaredk3nt I pulled the opacity way down (#74dfc41e), but the color looks off to me, for lack of a better description. Here's that previously mentioned color in action: image

All the text is more legible to me but it reminds me of the standard vscode styling, but off color. I personally think the maximum blue cuts through more, however I'll defer to your choice on this.

Jaredk3nt commented 4 years ago

Actually I think you are right on this one the blue is cleaner. I would still drop the opacity just a bit but I think we can move forward with essentially what you originally suggested