search

Jaredk3nt / laserwave

A retro outrun / cyberpunk inspired VS Code theme
https://marketplace.visualstudio.com/items?itemName=jaredkent.laserwave
MIT License
141 stars 20 forks source link

Support diff language view #40

Closed TGiles closed 3 years ago

TGiles commented 3 years ago

Currently if you view a .diff file with Laserwave, there's no highlighting on the added and removed parts of the diff. This makes it harder to tell which lines were added/removed compared to other color themes. Considering other themes have this feature I guess it's just some additional TextMate that needs to be defined.

@Jaredk3nt what colors out of the palette would you want for this? It looks like the + and - symbols can be customized to be different that the lines of text they're on as well as the "diff header" since I don't know what it's actually called...the part that says diff --git a/file b/file

I feel like I can take this on and get a PR up in a day or two

Jaredk3nt commented 3 years ago

I don't think I have used .diff files before so I'm not exactly sure what the UI looks like in VS Code. I would imagine it would look like the git diff view though which already has some defined colors

image

It basically just uses a transparent version of Maximum Blue and Hot Pink in place or red/green. So as long as it follows that pattern i'm up for it 👍 . Having the -/+ be the full version of the color would be pretty sweet looking as well.

If i'm missing anything post some examples here from other themes and I can weigh in

TGiles commented 3 years ago

Gotcha, sounds good. I'll post some examples so you're aware. I'll include the diff file I'm using as part of the examples for future reference.

2077 theme image

Dark (visual studio) image