Jaredk3nt / laserwave

A retro outrun / cyberpunk inspired VS Code theme
https://marketplace.visualstudio.com/items?itemName=jaredkent.laserwave
MIT License
141 stars 20 forks source link

Add support for diff files #41

Closed TGiles closed 3 years ago

TGiles commented 3 years ago

This change adds support for some common situations involving diff files. Closes #40

I didn't include it in this change but something I've seen in other themes is punctuation.definition.changed.diff but I couldn't figure out what it matched, so maybe that's something that can be added later once someone figures out what it corresponds to.

Jaredk3nt commented 3 years ago

Awesome! Could you add some screenshots here of it as well 👍

TGiles commented 3 years ago

First, the regular theme image

Second, the high contrast theme image

Hope this helps!

Jaredk3nt commented 3 years ago

Sorry for the delay in responses I should have some free time tonight to look through everything for real!

TBH since the aqua is in the file, it almost feels like that should be used for additions rather than the blue since green is typically used and that is much more green... I might play around with how it looks in the git diff view as well. Curious on your thoughts

TGiles commented 3 years ago

no worries, I understand being a maintainer :) there's no rush on my end, just trying to make the theme even better 🎉

TBH since the aqua is in the file, it always feels like that should be used for additions rather than the blue.

Let me make sure I understand correctly, the suggestion is swap out the coloring used for diff --git for the coloring used for inserting new lines? It'd probably be more cohesive since green is typically used for inserts, not entirely sure why I went with the blue for inserts over green lol.

Jaredk3nt commented 3 years ago

I also use maximum blue in the VSCode source control tab to highlight added code, but now that the lines are actually colored rather than highlighted with it it's more obvious that its blue when it should be green.

I'm going to try out the green in both cases tonight and see if I think that looks more natural in both this case and the existing one.

Jaredk3nt commented 3 years ago

Released in v1.3.3 🎉

Thanks for keeping LaserWave awesome!!