search

JarekToro / responsive-layout

The layout to beat them all!
https://vaadin.com/directory#!addon/responsive-layout
57 stars 24 forks source link

Increase precision to CSS class to correct wrong behaviour #25

Closed eRfO closed 7 years ago

eRfO commented 7 years ago

We have to add these CSS classes to fix a wrong behaviour with some display resolutions:

@media only screen and (min-width: 75em) {
  .rl-col-lg-2 {
    -ms-flex-preferred-size: 16.66666667%;
    flex-basis:16.66666667%;
    max-width: 16.66666667%;
  }
}

@media only screen and (min-width: 62em) {
  .rl-col-md-2 {
    -ms-flex-preferred-size: 16.66666667%;
    flex-basis: 16.66666667%;
    max-width: 16.66666667%;
  }
}

@media only screen and (min-width: 48em) {
  .rl-col-sm-2 {
    -ms-flex-preferred-size: 16.66666667%;
    flex-basis: 16.66666667%;
    max-width: 16.66666667%;
  }
}
JarekToro commented 7 years ago

Thank you for the code fixes, what is the "wrong behavior" your experiencing

JarekToro commented 7 years ago

@eRfO I would like to add this. I just need a description of what had how this fixes it.

JarekToro commented 7 years ago

Closing for now. @eRfO feel free to comment back id love to know more.

eRfO commented 7 years ago

@JarekToro i post 2 images that show the wrong behavior. The first image is an example without the fix while the second show the right behavior.

without-fix with-fix

JarekToro commented 7 years ago

Perfect thank you.

JarekToro commented 7 years ago

Added and tested code. Thanks again. I will upload to Vaadin Directory soon and close this after.

JarekToro commented 7 years ago

Apologizes on the extremely long delay.

Fixed in latest release. Now on Vaadin Directory