search

JarekToro / responsive-layout

The layout to beat them all!
https://vaadin.com/directory#!addon/responsive-layout
57 stars 24 forks source link

ResponsiveColumn introduces an unnecessary div #43

Open chvndb opened 7 years ago

chvndb commented 7 years ago

Is there a specific reason why ResponsiveColumn extends StyleableComponent and not CssLayout?

This introduces an unnecessary div, which makes css tweaking more difficult.

JarekToro commented 7 years ago

I can't remember the exact reason offhand but I attempted to use CSSLayout initially, However something didn't pan out with it, it may have been a Vaadin Quirk or how the CSS I was using needed to be structured.

chvndb commented 7 years ago

I see, in that case it might be better to avoid the extra div and avoid any unexpected quirks.