search

JarekToro / responsive-layout

The layout to beat them all!
https://vaadin.com/directory#!addon/responsive-layout
57 stars 24 forks source link

Remove the 'visible' tags since they are causing issues on Grids and … #56

Open bassmartin opened 6 years ago

bassmartin commented 6 years ago

…they don't seem required for good functioning.

This is a proposed fix for issue #51

They 'visible' classes don't seem to add anything required, so I'm not sure why we would need them.

Feel free to discuss, I just want to find a fix for my issue.

JarekToro commented 6 years ago

It is needed for some undocumented circumstances. If you want it hidden on Xs but visible of large you need the visible css

JarekToro commented 6 years ago

However the issue is probably that the default visible changes the display property. Standard bootstrap has multiple visible classes for various display properties. Which is not currently implemented properly.

bassmartin commented 6 years ago

I’m not sure to follow.

What I am experiencing is that nothing is changing between not using the « visible » tag and removing the code that add it when setting visibility rules on columns.

So, my guess is that it does not add anything useful in the UI.

I might be wrong though. It would be awesone to have feedback from other users.