search

JarlPatrick / eoa

MIT License
1 stars 3 forks source link

Handling of results with missing names / codes #33

Open marko213 opened 3 years ago

marko213 commented 3 years ago

Some competitions ("Maateaduste olümpiaad 2018/2019", for example) have results with names and codes mixed. For competitions where both a name and a code were available for the students, the codes have been omitted so far in favor of names.

However, if there is no name (but a code), should code could be stored in competitor and the person id be left NULL; or a placeholder person be used and all codes ignored? Similarly, what should be done for competitors who don't even have a code? Currently, there is one example here (references person "-") and another one here (name removed, references person "(nimi eemaldatud)").

I'd go for storing the code in competitor if and only if the name is missing, and have the entries with completely missing names have person_id set to NULL (which would need to be handled separately).

marko213 commented 3 years ago

The relevant results have been uploaded, currently with a new person for each such code. I still think attaching a "display name" to the contestant table and allowing the person_id to be NULL in such a case would be a good idea. This would also allow any contestant's "display name" to be changed independently of their actual name on a per-participation basis, but I don't see how that feature could really be used.