Check distro and install multiverse repo if = Ubuntu

Jarli01 / xenorchestra_installer

A simple install script for Xen Orchestra

GNU General Public License v3.0

428 stars 86 forks source link

Check distro and install multiverse repo if = Ubuntu #27

Closed bnrstnr closed 6 years ago

bnrstnr commented 6 years ago

Tested on clean Debian 9.5 and clean Ubuntu with, and without, multiverse already installed.

Danp2 commented 6 years ago

This looks fine to me. I would suggest that we also change the line

/usr/bin/apt-get install --yes build-essential redis-server libpng-dev git python-minimal libvhdi-utils nfs-common

by adding this to the end

|| echo "Aborting due to failure to install dependencies. Please see troubleshooting guide." && exit

bnrstnr commented 6 years ago

Good call @Danp2 I'll add this to the PR.

Edit: tested on both Ubuntu installs and works. Haven't tested Debian.

bnrstnr commented 6 years ago

I thought I tested with @Danp2's stuff, but apparently I didn't. For some reason it just stops later in the build. I've removed his code for now and will play with it tomorrow morning some and do another PR if I can get it working.

This PR should work as it is right now though.