search

Jarli01 / xenorchestra_installer

A simple install script for Xen Orchestra
GNU General Public License v3.0
428 stars 86 forks source link

Banner removal #45

Closed Jarli01 closed 5 years ago

Jarli01 commented 5 years ago

I just build on 18.04 without issue and this removed the banner. Can you test and let me know.

On Ubuntu Srv 19 there is a build issue that needs to be looked at. I'll post the install logs for that.

Danp2 commented 5 years ago

Sorry.... out of town with limited access at times. I'll take a look when I have a chance. I wonder if this is a good thing (completely removing the banner) vs some other alternative (ie: Change the wording to refer them to the GH repo for support).

On Wed, May 1, 2019 at 2:55 PM Dustin B notifications@github.com wrote:

Merged #45 https://github.com/Jarli01/xenorchestra_installer/pull/45 into master.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/Jarli01/xenorchestra_installer/pull/45#event-2312708640, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWFXAMPOGSSUEQOJ3K5LZTPTHYT7ANCNFSM4HJVALNA .

Jarli01 commented 5 years ago

We could change the verbiage on the banner, but the banner itself was pretty annoying as it stretched across the top of the browser.

I've made additional changes on that additional PR that directs people to this GH first for support, from which we can escalate to vatesfr if there is bug.

Jarli01 commented 5 years ago

I'm not sure how we would skip, just this section. I suppose we could just as easily find each line and insert comment marks nulling this section while still leaving it "intact".

Danp2 commented 5 years ago

I think the simple fix is to modify this line {+process.env.XOA_PLAN === 5 && ( by changing the 5 to a different value, ie 15.

Jarli01 commented 5 years ago

I'll test here and see if it works.

Jarli01 commented 5 years ago

So that change did work, switching to 15 for example.

Danp2 commented 5 years ago

@Jarli01 FYI -- Looks like they are preparing to make additional changes to this code.

https://github.com/vatesfr/xen-orchestra/pull/4278

Jarli01 commented 5 years ago

Yeah I noticed this a few days ago, the easy fix, assuming this change they are creating would be to just remove the edit we put in to remove the banner.

Hopefully the change they are creating allows for permanently disabling the banner.