search

Jarli01 / xenorchestra_installer

A simple install script for Xen Orchestra
GNU General Public License v3.0
428 stars 86 forks source link

Adding a dependency installation for debian 9.9.0 which seems to lack it #53

Closed Jarli01 closed 5 years ago

Jarli01 commented 5 years ago

Per issue https://github.com/Jarli01/xenorchestra_installer/issues/52 Debian 9.9.0 (and up presumably) is lacking a required dependency to make this work.

Tested locally.

Danp2 commented 5 years ago

How did you determine that this package was the issue? FWIW, the "official" docs don't call for this package.

Jarli01 commented 5 years ago

Built 9.9.0 saw the error, installed the dependency and the ran the install without issue.

Jarli01 commented 5 years ago

Instead of placing on this line, it should go on the line where all of the other dependencies are installed.

This isn't a dependency of XO, and thus I think makes more sense to leave above those as it's at the OS.

Moved, please test the build with it on the new line. As this isn't a XO dependency I don't think it should go there, but instead be a part of the OS dependencies section above. In either case it should work and the position really doesn't effect it (i think).

Again please test.

Jarli01 commented 5 years ago

Worth considering - should we just install everything on a single line or keep these dependencies separate? Currently we're using apt-get twice, which is a bit of a code bloat when we call it just a few lines later for the XO dependencies.

Danp2 commented 5 years ago

Now that I see the actual error is result of installing Yarn and not XO, I believe your original solution to be better.