Jarnsen / ha-xsense-component_test

HACS Integration for X-Sense devices
https://de.x-sense.com/
54 stars 0 forks source link

Test button disappears for XS01-M after adding XHO2-M and SC07-MR / Add test button for XHO2-M and SC07-MR #11

Open jamesg226 opened 1 week ago

jamesg226 commented 1 week ago

Voraussetzungen / Prerequisites

Versionsinformationen / Version Information

Bitte geben Sie die verwendeten Versionen an:
Please specify the versions used:

Beschreibung des Problems / Problem Description

Beschreiben Sie das aufgetretene Problem detailliert.
Describe the problem in detail. Upon adding the heat detector SC07-MR and combined smoke and carbon monoxide detector SC07-MR to the xsense base station, the test button for the smoke detector XS01-M is no longer being provided by the integration. The test button was working fine before.

Schritte zur Reproduktion / Steps to Reproduce

  1. Schritt 1 / Step 1 Setup integration with only smoke detectors XS01-M and base station
  2. Schritt 2 / Step 2 Add heat detector SC07-MR and combined smoke and carbon monoxide detector SC07-MR to the system
  3. Schritt 3 / Step 3 Try and run a test on smoke detectors

Erwartetes Verhalten / Expected Behavior

Beschreiben Sie, was Ihrer Meinung nach passieren sollte.
Describe what you expected to happen. Nothing, I expected the test to stay enabled in XS01-M

Screenshots oder Logs / Screenshots or Logs

image

Fügen Sie bei Bedarf relevante Screenshots oder Log-Dateien hinzu.
Add relevant screenshots or logs if needed.


Weitere Hilfe / Additional Help

Falls Sie zusätzliche Unterstützung benötigen, können Sie diese Ressourcen nutzen:
If you need additional support, you can use these resources:

Jarnsen commented 1 week ago

Hello [@jamesg226],

Regarding your issue, I wanted to point out that the SC07-MR has not yet been fully integrated by Theo. This may be the reason for the Test button disappearing on the XS01-M smoke detector after adding the SC07-MR and the XH02-M.

It might help to go through the setup step-by-step and add each device individually to determine exactly which one is causing the issue. Since the XH02-M is already supported, the SC07-MR could be the source of the problem.

If it turns out that the SC07-MR is indeed causing this, I suggest sharing this with Theo so that it can be fully integrated. Unfortunately, Theo currently has a lot on his plate, so it may take a bit of time to address.

Hope this helps, and that we can find a solution for the integration together!

Best regards,

jamesg226 commented 1 week ago

Hello, Thanks for the response! Ah yes I got my model numbers mixed up!

The SC07-MR is fully working hence the initial confusion. I did some testing and removed the SC07-MR - this did indeed cause the test button to come back for XS01-M. I'd still say this is a bug as XS01-M is a supported device.

Sharing with Theo would be good. Hopefully support can be added soon for this and for a test button on the XH02-M and SC07-MR!

Thanks

Jarnsen commented 6 days ago

So can i close the issue?

jamesg226 commented 6 days ago

Can we get this as a feature request to add test buttons to all devices?

Or to have the SC07-MR added as a supported device? Still seems a bug for the XS01-M device. The SC07-MR is working perfectly fine!

Jarnsen commented 5 days ago

I’ll pass this on to Theo. Support for the test buttons is planned, but it’s currently only possible for devices where this feature is available in the app. For now, keep it as a feature request.

jamesg226 commented 5 days ago

Perfect thank you. I'll edit the title to show the update.

Test button shows in the app for SC07-MR and XH02-M :)