JarodMica / ai-voice-cloning

GNU General Public License v3.0
656 stars 144 forks source link

Add set -e to bash scripts to make it easier to spot/find errors #20

Closed simcop2387 closed 10 months ago

simcop2387 commented 10 months ago

Just a small quality of life update. Adding this means that if there's any errors when running the commands in the scripts, it'll exit immediately, making it easier to see the problem. This can easily happen during building/installing tortoise because it requires a modern and working rust compiler to fully build from source here. This should make it easier to spot the problem since the error won't be pushed way up by the other pip commands.

JarodMica commented 10 months ago

Hey sim,

Appreciate the PR, however, I'm going to reject it as the latest updates on the repo for adding RVC will be breaking the .sh scripts. If you endeavor to adjust the latest ones for linux, just open a new PR and I'll review it at the time!