search

Jarred-Sumner / git-peek

git repo to local editor instantly
MIT License
722 stars 17 forks source link

Bad credentials? #12

Closed dscho closed 3 years ago

dscho commented 3 years ago

I just tried this at home, and it failed:

$ git peek https://github.com/git-for-windows/git/pull/3017
Failed to load pull request url: HTTP  401
 {"message":"Bad credentials","documentation_url":"https://docs.github.com/rest"}

Why does it need credentials to begin with?

dscho commented 3 years ago

I think I found the reason: https://github.com/Jarred-Sumner/git-peek/blob/885e324360f00ff030f44fcd99f4ea29f98b459b/src/Search.tsx#L42

Once upon a time, long, long ago, I had hub installed (which, as far as I understand at least, has been replaced by GitHub CLI), and it had a stale PAT in ~/.config/hub. Apparently that was used.

Jarred-Sumner commented 3 years ago

🤔 maybe using hubs automatically is too “smart”. I guess I can have a config file it can load. But I’m wary of introducing more complexity.

I wonder if there’s a way I could use ~/.gitconfig? Or maybe, just have a ~./.git-peek.env file which just comes preloaded with each CLI argument as environment variables. Then, each flag is both globally configurable and per-run configurable. And setting environment variables is kind of familiar? It will have all of them listed in the file so it will be somewhat self documenting

Jarred-Sumner commented 3 years ago

Also, to clarify — the reason for credentials was because I kept getting rate limited in my own usage because the search is very aggressive about sending requests to their api due to short debounce time. Also for private repos. But it kind of backfires if it means copying doesn’t work

dscho commented 3 years ago

In my mind, having support for the environment variable GITHUB_TOKEN is plenty enough, no need to look at (and use) hub's token.

Jarred-Sumner commented 3 years ago

You're right.

Added in 1.1.30 - https://github.com/Jarred-Sumner/git-peek/releases/tag/1.1.30