search

Jarred-Sumner / git-peek

git repo to local editor instantly
MIT License
722 stars 17 forks source link

improve error message for unsupported EDITOR #21

Closed AndrewSB closed 3 years ago

AndrewSB commented 3 years ago

track something to improve error messaging for unsupported $EDITORs? nvim isn't supported right now, and it isn't clear at all that it doesn't work

Screen Shot 2021-02-16 at 12 27 50 PM
Jarred-Sumner commented 3 years ago

Hmmmm

Try running git peek nextcloud/ios -e nvim

Does nvim open directly in the terminal for you or does it open in a separate app? Right now, the code assumes any vi* will open in the terminal

Jarred-Sumner commented 3 years ago

There's a difficult to reproduce issue where the $EDITOR var when set from the shell (i.e. not ~/.git-peek) is not propagating to git-peek's node.js instance and I'm not sure why.

Jarred-Sumner commented 3 years ago

nvim is now fixed (as of v1.3.17) and fixed a related bug with detecting the editor