search

Jarva / VelocityCarbonDiscord

4 stars 2 forks source link

[Feature] Parse all configurable strings via MiniPlaceholders #3

Closed unilock closed 9 months ago

unilock commented 9 months ago

It would be nice to have all strings available in the configuration parsed through MiniPlaceholders, to allow for much more customization than just the placeholders made available by VelocityCarbonDiscord. (I noticed this was not already the case when attempting to use <server_name> in #2.)

At the very least, I think it would make sense for the following strings to be parsed through MiniPlaceholders:

discord:
   messages:
      chat_message: '<username>: <message>'
      join_message: '**<username> joined <server>**'
      leave_message: '**<username> left <server>**'
      disconnect_message: '**<username> was disconnected**'
      server_switch_message: '**<username> moved from <previous_server> to <server>**'
   webhook:
      username: '<username>'
      message: '<message>'
unilock commented 9 months ago

This is already implemented; I should have been using Player Expansion + <player_current_server> instead of <server_name>. (oops)