Protected Branch

[Bartek20]

@Jarvis-Ank could you disable the protected branch in the repository, because I can't make changes directly in the main branch, but I have to create separate ones for each patch.

[Jarvis-Ank]

@Bartek20 hey check it out now.. i've added push permissions for you. that should work.

[Bartek20]

Unfortunately it didn't change anything, from what I found out you can give me some "bypass branch protections" role and it should work. More information you have here

[Jarvis-Ank]

I didn't found any options to do so. Please link me to that.

Aswin N Kaimal

On Tue, Sep 13, 2022, 8:15 PM Bartek20 @.***> wrote:

Unfortunately it didn't change anything, from what I found out you can give me some "bypass branch protections" role and it should work. More information you have here https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches

— Reply to this email directly, view it on GitHub https://github.com/Jarvis-Ank/Re-Vanced/issues/17#issuecomment-1245521762, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSEXTABKS63TYBVII4UFB3V6CHSBANCNFSM6AAAAAAQKWXYWE . You are receiving this because you modified the open/close state.Message ID: @.***>

[Bartek20]

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches

That's everything i found about protected branches.

[Bartek20]

Maybe this will allow me to make changes in main branch. https://github.com/Jarvis-Ank/Re-Vanced/settings/branch_protection_rules/new

[Jarvis-Ank]

I've already done that. That's why I asked you to check.

Aswin N Kaimal

On Thu, Sep 15, 2022, 7:15 PM Bartek20 @.***> wrote:

Maybe this will allow me to make changes in main branch.

https://github.com/Jarvis-Ank/Re-Vanced/settings/branch_protection_rules/new [image: image] https://user-images.githubusercontent.com/67280540/190419913-a8705634-626b-466f-b025-be134b9e6953.png

— Reply to this email directly, view it on GitHub https://github.com/Jarvis-Ank/Re-Vanced/issues/17#issuecomment-1248124079, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARSEXTER5VLYPLVTTKORCQDV6MSAFANCNFSM6AAAAAAQKWXYWE . You are receiving this because you modified the open/close state.Message ID: @.***>

[Bartek20]

I read a bit and to add this role "bypass branch protections" is the account to which the repository belongs to have to belong to the organization.

But I found a way to make changes. You only need to disable the code review requirement and then I will be able to merge my pull requests.

[Jarvis-Ank]

it comes with security issues. i think we'll keep it as it is now. i'll try to check PR more often.

[Bartek20]

Then maybe you will add my 2nd test account as a collaborator and then I will be able to give myself reviews.