search

JarvusInnovations / SeptaMobi

3 stars 1 forks source link

"Current Location" should be placeholder instead of value #2

Open themightychris opened 10 years ago

themightychris commented 10 years ago

When current location is activated on the trip planner form, "current location" is set as the value on the input field. This enables it to be edited, searched for, and cleared. Instead, the field should be disabled and "current location" should be set as placeholder text

BillClinton commented 9 years ago

textfields were already being disabled/enabled. I added a check in onAddressFieldTap() so the selectAddressPanel is only shown if the textfield is not disabled. And I added a handler for the clear icon so the field is re-enabled when cleared.

https://github.com/BillClinton/SeptaMobi/commit/4161b96c2dba67395137b13be02f9a086fdc6aaf

BillClinton commented 9 years ago

updated code after suggestions by Chris here: https://github.com/BillClinton/SeptaMobi/commit/6d1b8f3c22fabc80f1db06066a97764f177acb51