search

Jarzka / stylefy

Clojure(Script) library for styling user interface components with ease.
MIT License
317 stars 10 forks source link

Non public function calls in Stylefy 1.10.0 #32

Closed jarnovayrynen closed 5 years ago

jarnovayrynen commented 5 years ago

When compiling Stylefy 1.10.0 with Figwheel, we get several warning of non public functions being called by the implementation:

WARNING: var: stylefy.impl.cache/cache-key-styles is not public at line 111 resources/public/js/out/stylefy/impl/dom.cljs WARNING: var: stylefy.impl.conversion/class-selector is not public at line 159 resources/public/js/out/stylefy/impl/dom.cljs WARNING: var: stylefy.impl.dom/save-style! is not public at line 60 resources/public/js/out/stylefy/impl/styles.cljs WARNING: var: stylefy.impl.dom/style-by-hash is not public at line 143 resources/public/js/out/stylefy/impl/styles.cljs WARNING: var: stylefy.impl.dom/update-dom is not public at line 176 resources/public/js/out/stylefy/impl/styles.cljs WARNING: var: stylefy.impl.dom/save-style! is not public at line 60 resources/public/js/out/stylefy/impl/styles.cljs WARNING: var: stylefy.impl.dom/style-by-hash is not public at line 143 resources/public/js/out/stylefy/impl/styles.cljs WARNING: var: stylefy.impl.dom/update-dom is not public at line 176 resources/public/js/out/stylefy/impl/styles.cljs

Jarzka commented 5 years ago

Were you able to compile it successfully despite the warnings? If not, try to use an older version.

Of course there should not be any compile warnings so I'll take look at this at some point.

K1ll3rF0x commented 5 years ago

Seems to me that they are just warnings by newer figwheel. I don't get any compilation errors.

jarnovayrynen commented 5 years ago

Yes it compiles so this is not so urgent.

Sent from mobile.

Jarzka commented 5 years ago

Should be fixed now in 1.10.1.

jarnovayrynen commented 5 years ago

Thanks, cool.