JaseZiv / worldfootballR

A wrapper for extracting world football (soccer) data from FBref, Transfermark, Understat
https://jaseziv.github.io/worldfootballR/
455 stars 60 forks source link

fb_match_lineups() not returning correct team #221

Closed vennanalysis closed 1 year ago

vennanalysis commented 1 year ago

I am using the fb_match_lineups() function on a range of World Cup Qualifier URLs and the team column does not seem to be correct.

For some entries the Home and Away team are mixed up, for other entries it shows "Major League Soccer"

Any help would be appreciated

Cheers, Daniel

pedroorden commented 1 year ago

I had the same problem but I checked the package changelog and I saw that this error is a recognized bug https://jaseziv.github.io/worldfootballR/news/index.html

JaseZiv commented 1 year ago

I am using the fb_match_lineups() function on a range of World Cup Qualifier URLs and the team column does not seem to be correct.

For some entries the Home and Away team are mixed up, for other entries it shows "Major League Soccer"

Any help would be appreciated

Cheers, Daniel

As @pedroorden stated, this issue should have been resolved.

Make sure you’ve installed the latest dev version.

Let me know if there’s still issues.

vennanalysis commented 1 year ago

Appreciate the responses - apologies for not checking the github version - my first time posting here

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Jason Zivkovic @.> Sent: Friday, November 18, 2022 6:25:15 AM To: JaseZiv/worldfootballR @.> Cc: vennanalysis @.>; Author @.> Subject: Re: [JaseZiv/worldfootballR] fb_match_lineups() not returning correct team (Issue #221)

I am using the fb_match_lineups() function on a range of World Cup Qualifier URLs and the team column does not seem to be correct.

For some entries the Home and Away team are mixed up, for other entries it shows "Major League Soccer"

Any help would be appreciated

Cheers, Daniel

As @pedroordenhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpedroorden&data=05%7C01%7C%7C22722f0995cc4713f9d508dac8d174ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638043099175078237%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VsuCvLp5tWymFB%2FWqjrVU76hXEgemZGyU%2Fqx%2F66U4QI%3D&reserved=0 stated, this issue should have been resolved.

Make sure you’ve installed the latest dev version.

Let me know if there’s still issues.

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJaseZiv%2FworldfootballR%2Fissues%2F221%23issuecomment-1319098747&data=05%7C01%7C%7C22722f0995cc4713f9d508dac8d174ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638043099175078237%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qt29VG0OO7ttlvUvG6HUGso4H4UBdH5%2FJLBDZFMpRlQ%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA4HUOSI73J2UYXQRGF6QY43WI2BBXANCNFSM6AAAAAASDH2RPY&data=05%7C01%7C%7C22722f0995cc4713f9d508dac8d174ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638043099175078237%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YeyU7GqPtHwqAPbj2t%2BlbbM5z%2BzilPIdQnCBHFtEhoo%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

vennanalysis commented 1 year ago

I installed via GitHub but still have the same issue (see below).

Using sessionInfo() I have the following version - worldfootballR_0.6.1.8000

fb_match_lineups(match_url = "https://fbref.com/en/matches/4b84070f/Jamaica-Mexico-January-27-2022-WCQ----CONCACAF-M")

image

JaseZiv commented 1 year ago

Sorry about this...

I've just tested myself and it looks like FBref have yet again changed their HTML and reintroduced this bug...

I will address it shortly.

Sorry for the hassle

JaseZiv commented 1 year ago

@vennanalysis install the latest dev version - this should now be fixed.

Thanks

rostagg commented 1 year ago

Hey great script these are so helpful!

Just wanted to say that this issue is occurring when using fb_advanced_match_stats too

test <- fb_advanced_match_stats(match_url = "https://fbref.com/en/matches/1b496cc1/Arsenal-Nottingham-Forest-October-30-2022-Premier-League",stat_type = "summary","player")

image