JaseZiv / worldfootballR

A wrapper for extracting world football (soccer) data from FBref, Transfermark, Understat
https://jaseziv.github.io/worldfootballR/
433 stars 59 forks source link

fotmob_get_league_matches responds with error #229

Closed dammfoolman closed 1 year ago

dammfoolman commented 1 year ago

df <- fotmob_get_league_matches(country = "ENG", league_name = "Championship")

responds with the following error

Error in .f(): ! Argument 1 must have names.

packageVersion("worldfootballR") [1] ‘0.6.2.1000’

sessionInfo() R version 4.2.2 (2022-10-31 ucrt) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 19044)

Matrix products: default

locale: [1] LC_COLLATE=English_United Kingdom.utf8 LC_CTYPE=English_United Kingdom.utf8 LC_MONETARY=English_United Kingdom.utf8 [4] LC_NUMERIC=C LC_TIME=English_United Kingdom.utf8

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] worldfootballR_0.6.2.1000 extrafont_0.18 dplyr_1.0.10

loaded via a namespace (and not attached): [1] pillar_1.8.1 compiler_4.2.2 tools_4.2.2 lubridate_1.9.0 jsonlite_1.8.4 lifecycle_1.0.3 tibble_3.1.8 timechange_0.1.1 [9] pkgconfig_2.0.3 rlang_1.0.6 DBI_1.1.3 cli_3.4.1 rstudioapi_0.14 curl_4.3.3 Rttf2pt1_1.3.11 xml2_1.3.3
[17] httr_1.4.4 stringr_1.5.0 janitor_2.1.0 generics_0.1.3 vctrs_0.5.1 hms_1.1.2 tidyselect_1.2.0 glue_1.6.2
[25] snakecase_0.11.0 R6_2.5.1 fansi_1.0.3 tidyr_1.2.1 purrr_0.3.5 readr_2.1.3 tzdb_0.3.0 extrafontdb_1.0 [33] magrittr_2.0.3 ellipsis_0.3.2 rvest_1.0.3 assertthat_0.2.1 utf8_1.2.2 stringi_1.7.8

dammfoolman commented 1 year ago

under a different OS I get a different error

df <- fotmob_get_league_matches(country = "ENG", league_name = "Championship") Error in clean_names.default(.) : No clean_names() method exists for the class list Consider janitor::make_clean_names() for other cases of manipulating vectors of names.

packageVersion("worldfootballR") [1] ‘0.6.2’ sessionInfo() R version 4.1.2 (2021-11-01) Platform: x86_64-pc-linux-gnu (64-bit) Running under: Ubuntu 22.04.1 LTS

Matrix products: default BLAS: /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.10.0 LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.10.0

locale: [1] LC_CTYPE=en_GB.UTF-8 LC_NUMERIC=C LC_TIME=en_GB.UTF-8 LC_COLLATE=en_GB.UTF-8 LC_MONETARY=en_GB.UTF-8 LC_MESSAGES=en_GB.UTF-8
[7] LC_PAPER=en_GB.UTF-8 LC_NAME=C LC_ADDRESS=C LC_TELEPHONE=C LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] worldfootballR_0.6.2

loaded via a namespace (and not attached): [1] rstudioapi_0.14 xml2_1.3.3 janitor_2.1.0 magrittr_2.0.3 hms_1.1.2 rvest_1.0.3 tidyselect_1.2.0 R6_2.5.1 rlang_1.0.6
[10] fansi_1.0.3 stringr_1.5.0 httr_1.4.4 dplyr_1.0.10 tools_4.1.2 utf8_1.2.2 cli_3.4.1 ellipsis_0.3.2 tibble_3.1.8
[19] lifecycle_1.0.3 tidyr_1.2.1 tzdb_0.3.0 readr_2.1.3 purrr_0.3.5 vctrs_0.5.1 curl_4.3.3 glue_1.6.2 snakecase_0.11.0 [28] stringi_1.7.8 compiler_4.1.2 pillar_1.8.1 generics_0.1.3 jsonlite_1.8.4 lubridate_1.9.0 pkgconfig_2.0.3

mbrownsword commented 1 year ago

Having the same issue.

JaseZiv commented 1 year ago

Sending out a bat signal to @tonyelhabr

mbrownsword commented 1 year ago

What is the best way to reload the package so that this function will now work?

tonyelhabr commented 1 year ago

if you really need it right away, you can do remotes::install_github('JaseZiv/worldfootballR', ref = 'fix-229-and-fotmob-tests'), then restart your R session. otherwise, you can wait till Jase merges that PR, then do remotes::install_github('JaseZiv/worldfootballR') (and restart your R session)

JaseZiv commented 1 year ago

PR now merged, so go ahead and install as Tony said using remotes::install_github('JaseZiv/worldfootballR')