search

JaseZiv / worldfootballR

A wrapper for extracting world football (soccer) data from FBref, Transfermark, Understat
https://jaseziv.github.io/worldfootballR/
444 stars 60 forks source link

Encoding issues on Windows for player_dictionary_mapping() #56

Closed mimburgi closed 2 years ago

mimburgi commented 2 years ago

Player names get returned like "Ömer Toprak". Specifying UTF-8 encoding explicitly within read.csv() in the function didn't work for me. Changing to readr::read_csv() with no additional arguments seems to solve the problem, like this:

function () { players_mapped <- readr::read_csv("https://github.com/JaseZiv/worldfootballR_data/raw/master/raw-data/fbref-tm-player-mapping/output/fbref_to_tm_mapping.csv") return(players_mapped) }

JaseZiv commented 2 years ago

Thanks for the suggestion! Will make a fix over the next 24 hours.

JaseZiv commented 2 years ago

Closing with commit https://github.com/JaseZiv/worldfootballR/commit/c6a6d951877009df6945e57783f65bc02691aed4