JaseZiv / worldfootballR

A wrapper for extracting world football (soccer) data from FBref, Transfermark, Understat
https://jaseziv.github.io/worldfootballR/
444 stars 60 forks source link

Error: object 'read_html' is not exported by 'namespace:rvest' #99

Closed QuantQB8 closed 2 years ago

QuantQB8 commented 2 years ago

Installing the package, it throws an error that rvest doesn't have read_html. Maybe is from package xml2?

JaseZiv commented 2 years ago

Interesting. Can you please provide the code and full error message that you're experiencing? Can be a screen shot if easiest.

Might also help if you try installing rvest and xml2 separately, then trying to install worldfootballR.

Let me know how you go.

tonyelhabr commented 2 years ago

I'm guessing you have a version of rvest less than 1.0.0. read_html is originally from xml2, but it's re-exported from rvest in versions >=1.0.0.

QuantQB8 commented 2 years ago

It worksssssssssss!!! Wuwuwuwu

On Sat, Mar 19, 2022 at 6:05 AM Tony ElHabr @.***> wrote:

I'm guessing you have a version of rvest less than 1.0.0. read_html is originally from xml2, but it's re-exported from rvest in versions >=1.0.0.

— Reply to this email directly, view it on GitHub https://github.com/JaseZiv/worldfootballR/issues/99#issuecomment-1072998234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYI4MWZ7T37WDQT4XAJLFRTVAW7JVANCNFSM5Q7ZEMIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

QuantQB8 commented 2 years ago

One last doubt,

Fotmob functions are only available in the repo, right? If I download from CRAN, they dont come

Sent from my iPad

On 19 Mar 2022, at 9:57, Roman Velez @.***> wrote:

 It worksssssssssss!!! Wuwuwuwu

On Sat, Mar 19, 2022 at 6:05 AM Tony ElHabr @.***> wrote: I'm guessing you have a version of rvest less than 1.0.0. read_html is originally from xml2, but it's re-exported from rvest in versions >=1.0.0.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

QuantQB8 commented 2 years ago

Hello! On last doubt:

When you fetch data from fotmob from the players, in the stats column that has a data frame inside, why are more than 1 row per user? For example, in your’s Salah example in the articles, it show 6 rows for the stats for one game. Which one is the “good” one? The first? The last?

Thanks! Román AVJ Sent from my iPad

On 19 Mar 2022, at 9:57, Roman Velez @.***> wrote:

 It worksssssssssss!!! Wuwuwuwu

On Sat, Mar 19, 2022 at 6:05 AM Tony ElHabr @.***> wrote: I'm guessing you have a version of rvest less than 1.0.0. read_html is originally from xml2, but it's re-exported from rvest in versions >=1.0.0.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

tonyelhabr commented 2 years ago

this was a bug noted in #98 . #100 fixes the issue. there should just be 1 row per player

JaseZiv commented 2 years ago

This has been resolved in v0.4.10.4000