Debugging Inconsistent field on translation

[Jashcraf]

r_ray and k_ray look good to me, let's try the ray transfer matrices.

A matrix

B Matrix

C matrix

D matrix

[Jashcraf]

top is new algo, bottom is old

overall the new one looks less regular, maybe an operation got broadcast over an unintended dimesnion

[Jashcraf]

Delta calculation

These actually just look like the right values in perhaps different places. Specifically - the middle two columns are switched

[Jashcraf]

K rays before delta calculation are the same, but different order

[Jashcraf]

Oh my god lData and mData were flipped in the function inputs

[Jashcraf]

Delta is good (left gbd, right beamlets)

[Jashcraf]

After orthogonal transformation

k_rays on both == np.array([0,0,1]), which is good! r_rays look a little different at first glance, can we use fewer beamlets without breaking?

[Jashcraf]

4x4 beamlets traces few enough to peruse. Seems like the comparison might be approaching numerical precision limits, this might be a thing with using numexpr for calculations?

[Jashcraf]

Gonna look at the +X differential ray, r_rays should basically all be at x,y = 0 here. They are different and transposed!

[Jashcraf]

Ah I think I might have been looking at the wrong coordinate here is the x,y,z position for each ray at a given pixel - which it is constant across consistency!

[Jashcraf]

plotting after the delta propagation, the beamlets array is entirely black?

[Jashcraf]

Oh it's because I'm passing it weird data, the rayset index is now in the first when it should be in the zeroth. consistency!

[Jashcraf]

Checking after orthogonal transformation. Might have some nan vals in the old method. Viridis is r_data and magma is k_data

Both look good (save the nans)

[Jashcraf]

Axx

Cxx - looks wrong

Bxx - looks wrong, values of near 50 are about what we'd expect given the HST focal length

Dxx - also doesn't look spectacular

[Jashcraf]

Ah I forgot to normalize the l vector in the orthogonal transfer matrix

Axx - looking good!

Cxx - looking good!

Bxx - looking good!

Dxx - tell me why im so excited

[Jashcraf]

WE WIN

time to try the misaligned case

[Jashcraf]

Breaks during misalignment and focus - I suspect that this has to do with where the ray positions are

[Jashcraf]

Nah the ray positions are identical

[Jashcraf]

Let's check the final ingredients for the matrix, starting with Amplitude

|Amplitude|

Looks slightly different, don't know what this could be from (other than the complex beam parameter computation)

Angle{Phase}

This is very different!

(The vertical lines are the new algorithm)

[Jashcraf]

For the misaligned case the ray transfer matrices are different!

Axx (left is beamlets right is gbd)

on-axis case for comparison

[Jashcraf]

Works for the defocused case

[Jashcraf]

The orthogonal transformation matrix is looking good, each image is a row in the matrix

[Jashcraf]

The detector coords are wrong!

[Jashcraf]

turns out you need to provide the offset to the rays, not detector

[trentjbrendel]

This is fascinating. Thanks for sharing, Jaren!