search

Jasig / jspc-maven-plugin

UNMAINTAINED Maven plugin that compiles JSPs
http://unmaintained.tech/
Apache License 2.0
24 stars 38 forks source link

Cannot use tomcat 7 newer than 7.0.57 #28

Closed sellersj closed 7 years ago

sellersj commented 8 years ago

Using 7.0.59 gives you the following error: Failed to execute goal org.jasig.mojo.jspc:jspc-maven-plugin:2.0.2:compile (default) on project MY_PROJECT: Execution default of goal org.jasig.mojo.jspc:jspc-maven-plugin:2.0.2:compile failed: An API incompatibility was encountered while executing org.jasig.mojo.jspc:jspc-maven-plugin:2.0.2:compile: java.lang.NoSuchFieldError: loader

If you do, then in org.codehaus.mojo.jspc.compiler.tomcat7.MultiThreadedJspC line 169 will not compile because initServletContext() is not a valid method anymore.

I believe that it's because of this commit to tomcat https://github.com/apache/tomcat70/commit/28267fd2d338ac649b54a0e0186848ae57e44517

Current TC 7.x is 7.0.68

Aside: why do jspc-compiler-tomcat7 and jspc-compiler-tomcat7-multithreaded use different versions of tomcat?

ChristianMurphy commented 7 years ago

Thanks for the report @sellersj! Would you be willing to open a pull request resolving the issue?

sellersj commented 7 years ago

Unfortunately I won't have time anytime soon. At best I could get back to this in the summer.