JasmineCT / portfolio

The starter portfolio repository, basically empty, but with a few helper files.
https://hopeful-morse-7f7dbf.netlify.com/
0 stars 0 forks source link

New Domain #19

Open JasmineCT opened 4 years ago

JasmineCT commented 4 years ago

I seem to be having some trouble pointing my portfolio website to my new domain. But GitHub doesn't seem to like it, saying in the master branch The tag pattern on line 123 in /_layouts/branding.html is not a recognized Liquid tag. Not sure how to fix this. I couldn't remember how to make it point from my coming soon page to my new domain. @thomasjbradley any ideas?

thomasjbradley commented 4 years ago

Your website is hosted on Netfliy, not on GitHub. Because GitHub doesn’t support the pattern library system.

Turn of GitHub Pages hosting in your GitHub settings & then sign into Netlify.com to change your domain.

JasmineCT commented 4 years ago

Ohhh okay that makes sense, I completely forgot about Netlify. Everything looks good on hover, and netlify(i changed it yesterday). But it still seems to be pointing to my coming soon page. When I turn off GitHub pages for my coming soon page it gives me a 404 page.

thomasjbradley commented 4 years ago

In Hover, where are your Name Servers pointed? It’s in the left column, near the bottom.

JasmineCT commented 4 years ago

I inputted the ones I got from Netlify into the hover name server spots.

Screen Shot 2020-10-12 at 1 03 22 PM Screen Shot 2020-10-12 at 1 04 05 PM
thomasjbradley commented 4 years ago

Okay. And you set up your domain on Netlify? When did you change the name servers on Hover? Within the last 48 hours?

JasmineCT commented 4 years ago

Yup I changed it on netlify yesterday, and I got my new domain a month ago.

thomasjbradley commented 4 years ago

Okay—it’s possible we are just running into time problems. Let’s give it another day or two and see if it starts working.

JasmineCT commented 4 years ago

Okay sounds great! Thanks so much for your help Thomas SO greatly appreciated!

JasmineCT commented 4 years ago

Hmm seems to be giving me this page now. On chrome, safari, firefox. When i click advance it gives me this.

Screen Shot 2020-10-13 at 6 32 09 PM

I went to netlify to check it and its saying this. Not sure if i just click renew because it has my old domain.

Screen Shot 2020-10-13 at 6 34 01 PM
thomasjbradley commented 4 years ago

Inside Hover, the name servers are pointed to Netlify for jasminegraphicdesigner.ca?

JasmineCT commented 4 years ago

In Netlify I changed the domain to my new one jasminecarlucci.ca, then I took the new DNS' and input them into hover. So they should be pointing to the new domain.

Screen Shot 2020-10-15 at 4 03 24 PM Screen Shot 2020-10-15 at 4 06 43 PM
thomasjbradley commented 4 years ago

The screenshot above, with the SSL error, shows your old domain.

JasmineCT commented 4 years ago

Yah I'm not sure why because I changed my domain

Screen Shot 2020-10-16 at 9 33 07 AM
thomasjbradley commented 4 years ago

Maybe try clicking the “Renew certificate” button?

JasmineCT commented 4 years ago

Okay I'll try that

JasmineCT commented 4 years ago

Oh gosh perfect, It worked!! Thanks so much Thomas! I appreciate your help so very much