search

Jason-Conner-NOAA / simfish

Produce INLA-generated density distributions of fish populations from survey data.
0 stars 1 forks source link

Reproducible Example #2

Open Jason-Conner-NOAA opened 5 years ago

Jason-Conner-NOAA commented 5 years ago

As Cole suggested, we need a reproducible example so we can compare changes in code to the original. We will need examples for the EBS, GOA, and AI. GOA and AI currently have issues in spatial extent, so the first work should be done on EBS.

Question: what is the folder structure for examples?

colemonnahan commented 5 years ago

I just pushed the proper structure (a good test). We should think about adding some more official tests via testthat in the future. But for now please update the EBS example so it runs. That'll be a great start.

Jason-Conner-NOAA commented 5 years ago

Thanks Cole, I will work on this after WKUSER.

On Thu, Nov 29, 2018 at 9:51 AM Cole Monnahan notifications@github.com wrote:

I just pushed the proper structure (a good test). We should think about adding some more official tests via testthat in the future. But for now please update the EBS example so it runs. That'll be a great start.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oceanconner/simfish/issues/2#issuecomment-442929549, or mute the thread https://github.com/notifications/unsubscribe-auth/AqIkyc_ydmb5nPuDMYjyavC-XOnm0b15ks5u0B6zgaJpZM4Y6HWM .