JasonCarter80 / concord232

Apache License 2.0
22 stars 17 forks source link

Arm stay silent - but encoding bug too? #4

Closed rwa closed 6 years ago

rwa commented 6 years ago

The original point of this branch was to allow a new command:

concord232_client arm-stay-silent

which is the equivalent of pressing "5" "2" on the keypad. I did implement this, but in the course of things discovered what seems to be a fairly major bug. In the encoding from binary to ascii, python uses lowercase for the hex letters. But the automation panel seems not to accept this, but rather only uppercase letters. The protocol manual does seem to specify this, if not all that clearly, when they say:

"Only sixteen ASCII characters '0'...'9', 'A'...'F' are used to transfer data."

I am not sure if you are still interested in maintaining this, but I thought I'd make the pull request and see what you think.