Handle Critical Hit Styles

[PanoramicPanda]

Handles the following Critical Hit Styles, using 1d8+2 as an example:

• Double all Die (2d8+2)
• Double all Die Results (1d8[2]*2+2=6)
• Double the Total ((1d8[2]+2)*2=8)
• Max Die (8+2=10)
• Max Die plus Roll (1d8+8+2)

Set style of Crit within the Settings.

[JasonCostanza]

Getting some odd behaviors here:

Both of these are crit rolls but a) it's not being doubled in the result b) the 2nd roll is actually coming through as a minimized chat message. Clicking that mini-gray bar expands the rest of the result which has some formatting issues which I'm not sure we can actually resolve as that's inside TS at that point

For all the above I am using "Double the total" result with crit radio button selected

[PanoramicPanda]

@JasonCostanza Should be fixed-ish.

I hadn't accounted for a single die type with no modifiers, so that's now working for all crit types. However, the display still overlaps a little when you do so, and that's just a problem with how Symbiotes handle text + 1 die type. It's a small problem and the information showing the type of roll is more important IMO.

Fun fact: the collapsed messages have been there since 1.0, as they show the original rolls before we swallow the results and send them back modified. So they're there for Adv/Dis too, and clicking it allows someone to see both rolls.

[JasonCostanza]

Fun fact: the collapsed messages have been there since 1.0, as they show the original rolls before we swallow the results and send them back modified. So they're there for Adv/Dis too, and clicking it allows someone to see both rolls.

That's wild, literally this entire time thought the white bars were just visual breaks between the rolls until we started this conversation about it 😆

Mechanics all look good, I'm unsure if we're labelling the crit settings clearly enough "Double all die" sounds too much like `doubling all die results" as I could easily hear the same message in 2 scenarios.

I'm brainstorming here or we can rely on player feedback in Discord with a poll:

• 2x Quantity of Dice
• 2x Sum of dice excluding modifier
• 2x Sum of dice and modifier
• Max roll possible
• Max roll possible + raw dice result

I think conceptually the example equations are nice but I fear people can't parse them well enough to really understand them

[PanoramicPanda]

How about:

• Roll Double the Die
• Double Sum of Die
• Double the Total Sum
• Max the Die Roll
• Max the Die + Raw Roll

[JasonCostanza]

I like it, let's run with that and we can get feedback in Discord if people are still unclear

On Sun, Apr 7, 2024 at 1:27 PM Uriah Brown @.***> wrote:

How about:

• Roll Double the Die
• Double Sum of Die
• Double the Total Sum
• Max the Die Roll
• Max the Die + Raw Roll

— Reply to this email directly, view it on GitHub https://github.com/JasonCostanza/Dice-Vault/pull/36#issuecomment-2041599980, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ6ZGEJ3FYFW4233ZXLKALY4GT2TAVCNFSM6AAAAABF24Q3KSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGU4TSOJYGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Jason Costanza E-mail: @.*** Cell: (209) 639-3155