JasonCostanza / Dice-Vault

Talespire symbiote for better dice rolling
2 stars 1 forks source link

Feature Request: Ability to edit saved rolls without having to delete and recreate them #4

Open JasonCostanza opened 6 months ago

JasonCostanza commented 6 months ago

As a player I want the ability to "Edit" a saved dice roll. Currently one must delete the roll and then recreate it.

PanoramicPanda commented 5 months ago

Thoughts on two types of behavior here:

  1. Edit roll interface is on the card itself. Is more direct of which roll is being edited, but could be cluttered. Especially if roll groups get added.
  2. Editing a roll sends the roll to the Roll interface at the top, perhaps changing bg-color to link the interface to the card. Save Roll becomes a "Save Edits" or something to also be more clear. Probably makes more sense in interface, but might be harder to visually connect the card to your edit area unless we're good about the visuals.

Opinions on which direction?

JasonCostanza commented 5 months ago

Part of me is leaning towards #2. It just creates the top area being the "Edit space" and the lower part just being the "vault space". Then there won't be confusion where you edit or situations of losing the cursor by accident, and no divergence what can be edited below vs. up top if the lower part ever became less than fully featured. But yes, we need to come up with something to visually pair editing with creating a new roll.

I think background color is a great first step or put a ts-icon-warning by "Roll Label" with loud text that says "Editing..." or something to draw attention. Then it only overwrites if the user hits the [Save Edits] button so they can still discard their changes or just it as a temporary change then reset when they're done leaving the stored option alone.

PanoramicPanda commented 5 months ago

I feel like that approach would work best. Clear separation of edit and non-edit space is a good idea.

PanoramicPanda commented 5 months ago

ts-icon-pencil can go in the card space reserved during #22