JasonCostanza / Dice-Vault

Talespire symbiote for better dice rolling
2 stars 1 forks source link

Feature Request: Add "gmOnly" rolls #6

Closed JasonCostanza closed 6 months ago

JasonCostanza commented 6 months ago

Looking at the rollEvent payload, there is a parameter for "GM Only" which is an interesting idea I haven't considered and apparently is supported


{kind: 'rollResults', payload: {…}}
kind: "rollResults"
payload: {rollId: '64424509441', clientId: '5a8814ba-f4bb-4ddb-a453-e930162e62e1', resultsGroups: Array(1), gmOnly: false, quiet: false}
[[Prototype]]: Object```
JasonCostanza commented 6 months ago

@PanoramicPanda is this the correct idea, we can add a UI element to make the roll a secret "DM Only" roll so players at the table won't see the result in chat?

PanoramicPanda commented 6 months ago

I believe it makes the message in the chat only appear to GMs, yes. However, since this symbiote puts the dice into the tray to be rolled and then the user can roll either public or GM, I don't think it's as useful. It doesn't hide the physical dice, that's up to the GM to roll from the GM box of the tray. I can double-check this behavior though to see if I'm correct.

PanoramicPanda commented 6 months ago

Yeah, since this is on rollResults and not putDiceInTray, this is just an indicator on the result on if it was rolled as a GM Roll I believe. Not a flag we can send over.

JasonCostanza commented 6 months ago

Oh I see! So we actually don't need to add any functionality here because if we wanted a GM roll, once we send to the tray we just drag out of the GM box from there which also natively covers hiding the results?

PanoramicPanda commented 6 months ago

Yes, this is automagically handled. In the screenshot below, you can see a gm dice roll and non-gm dice roll on the table, and the player only sees the non-gm result in the chat.

image