search

JasonEtco / build-and-tag-action

📦🔖 A GitHub Action for publishing JavaScript Actions
MIT License
92 stars 38 forks source link

Additional files #20

Open martijngastkemper opened 2 years ago

martijngastkemper commented 2 years ago

I use wordpos in an action. It's currently inpossible to publish that package because it has additional files in dist:

Screenshot 2021-11-12 at 09 55 43

And only dist/index.js is added to the Automatic compilation commit. After looking into the code I think it's not possible to add the whole dist folder with your package. But correct me if I'm working.

nthings commented 2 years ago

https://github.com/JasonEtco/build-and-tag-action/pull/24 added this pull request because I stumbble with that requirement as well

jayqi commented 1 year ago

Hi @JasonEtco, would it be possible to incorporate this feature? (There are already open PRs #18 and #24 which have possible implementations of this.)

In addition to not supporting actions that need additional files, this also doesn't allow including licenses, which seems like bad OSS etiquette at a minimum and violating license agreements with a stricter stance. This comment also points out that the marketplace page for older versions end up with blank descriptions because there is no README.

I also like this comment's suggestion of using the files keyword on the package.json spec which is intended to allow for specifying exactly this kind of thing.

lbruun commented 1 year ago

yes, please !!

teunmooij commented 12 months ago

You can try this action: https://github.com/marketplace/actions/github-versioned-release