search

JasonEtco / create-an-issue

A GitHub Action for creating a new issue from a template file.
MIT License
258 stars 83 forks source link

Release v2.8.0 to v2 tag #138

Closed Nemo157 closed 1 year ago

Nemo157 commented 1 year ago

I was wondering why my actions were still getting the Node 12 warning despite #136 having been fixed for 15 days in v2.8.0, until I realised that actions doesn't actually use versioning and relies on mutable tags and the v2 tag is still pointing at the same commit as v2.6.0. Will you update this tag, or should I update my workflows to use v2.8.0 directly?

JasonEtco commented 1 year ago

Done, should be fixed now! I'm not sure why it didn't automatically update the v2 tag when I published 2.8.0.

james-s-w-clark commented 1 year ago

@JasonEtco I'm still seeing this:

- uses: JasonEtco/create-an-issue@v2

A successful run of the Action gives:

image

I have never published an Action before, but it does seem a bit weird as I see a V2 tag that corresponds to v2.9 / v2.9.1 (all the same hash, e27dddc). It seems having this tag wasn't enough?

JasonEtco commented 1 year ago

@IdiosApps that warning is in reference to actions/checkout - you'll want to update your workflow to point to actions/checkout@v3.

james-s-w-clark commented 1 year ago

@IdiosApps that warning is in reference to actions/checkout - you'll want to update your workflow to point to actions/checkout@v3.

D'oh! I copy pasted from https://github.com/JasonEtco/create-an-issue/blob/main/README.md, and obviously didn't read the error message 😅 I'll raise a PR :) Edit: https://github.com/JasonEtco/create-an-issue/pull/147

I see your workflows are on actions/checkout@v3 👍. I added a lot of GitHub Action dependabots before, seeing repos using older Action versions. If you want, I can raise a PR for that with my dependabot-discovery script. It'd help when checkout@v4 is out - but wouldn't update the readme unfortunately.