search

JasonEtco / todo

🤖✅ GitHub App that creates new issues from actionable comments in your code.
https://todo.jasonet.co
ISC License
750 stars 70 forks source link

[BUG] Doesn't seem to be working #277

Closed thislooksfun closed 3 years ago

thislooksfun commented 3 years ago

Describe the bug In the last day I have pushed multiple commits containing TODOs and no issues were created for them. Yes I checked that the TODO app is enabled both on my account and on the repo itself, and it worked on another repo of mine the other week.

To Reproduce N/A, unfortunately

Expected behavior I expect that the TODO issues would be created.

Screenshots N/A

Additional context commit 1, commit 2

joshuabalduff commented 3 years ago

Is this thing broken now

thislooksfun commented 3 years ago

I've done some light investigating (so my conclusion here might be wrong). It seems that this bot only checks the files changed in the last commit pushed, not since the last push.

Namely this series of actions will result in the bug:

  1. Add a TODO to file A.
  2. Commit file A.
  3. Change file B.
  4. Commit file B.
  5. Push both changes.

After you push the bot will check the files changed in the last commit (the one on file B) and thus won't ever see the TODO in file A.

stale[bot] commented 3 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

thislooksfun commented 3 years ago

This is definitely still relevant.

stale[bot] commented 3 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

thislooksfun commented 3 years ago

Absolutely relevant

JasonEtco commented 3 years ago

Hi 👋 I've decided to shut down this project - please see https://github.com/JasonEtco/todo/discussions/293 for more information 🙏