JasonHHouse / gaps

Find the missing movies in your Plex Server
MIT License
568 stars 33 forks source link

Remove restriction on iframe use #139

Open Chipa001 opened 4 years ago

Chipa001 commented 4 years ago

Trying to use GAPS within Organizr, but due to restrictions in code it cannot be used in an iframe.

Would it be possible to add a checkbox to optionally remove the restriction? At least then it would be a little bit safer than removing restrictions totally. I have not searched through to find what method is used to restrict iframes so far, so not sure on the difficulty.

JasonHHouse commented 4 years ago

I'll test out some options and let you know.

rg9400 commented 4 years ago

Is this due to some restrictions? I have this issue as well, but my guess was that it was trying to load resources over http, namely the Plex thumbnails that are not actually being stored by GAPS, and so you'd get a mixed content issue when trying to load it over Organizr

haxx0r07 commented 3 years ago

Any update on this? I'm attempting to use Gaps with Organizr, but the iFrame restriction is preventing it from loading.

JasonHHouse commented 3 years ago

I looked into this and I didn't see any iFrame restrictions in the code. Do you have logs or more information to help identify the specific issue?

haxx0r07 commented 3 years ago

Chrome Dev Tools is showing

Refused to display 'https://FQDN/libraries' in a frame because it set 'X-Frame-Options' to 'deny'.

I'm running through the LinuxServer.io SWAG reverse Proxy using a subdomain, if that helps. The Gaps website will load fine if I open in a new window, and all of my other reverse proxied applications load without issues in an iframe

JasonHHouse commented 3 years ago

I pushed up a build on alpha if you could please test. docker pull housewrecker/gaps:alpha

haxx0r07 commented 3 years ago

Closer, now dev tools is showing

Refused to display 'https://gaps.FQDN/libraries' in a frame because it set 'X-Frame-Options' to 'sameorigin'.

JasonHHouse commented 3 years ago

Is FQDN the complete address for the origin? If not, ping me that, I'll hard code yours in to test and then can add the work to make a property.

haxx0r07 commented 3 years ago

Sorry for the delay.

The FQDN is https://geekflix[.]grunetworks[.]com This is a LinuxServer.io Swag proxy that sends the root to an Organizr container. From within that site is where I load all of my sub sites like Gaps.

alejakun commented 2 years ago

Hi,

I'm not using Organizr but Muximux but stumbled into what I think is the same problem, perhaps the error can help to solve this issue:

Mixed Content: The page at 'https://muximux.example.com/' was loaded over HTTPS, but requested an insecure frame 'http://gaps.example.com/libraries'. This request has been blocked; the content must be served over HTTPS.