search

JasonHHouse / gaps

Find the missing movies in your Plex Server
MIT License
569 stars 33 forks source link

Add OMDB API #143

Open JasonHHouse opened 4 years ago

JasonHHouse commented 4 years ago

Is your feature request related to a problem? Please describe. TMDB is slow

Describe the solution you'd like Same functionality but able to use OMDB

Describe alternatives you've considered None

Additional context

maverick1872 commented 3 years ago

Has there been any progress on this or could I potentially help out?

JasonHHouse commented 3 years ago

I was standing up and testing out the API. Do you have experience in Java or JS?

maverick1872 commented 3 years ago

I was standing up and testing out the API. Do you have experience in Java or JS?

I have experience in both. More JS than Java recently though.

JasonHHouse commented 3 years ago

I can take the Java and you the JS if you want. I just need the API key passed backed in a call. I normally put a save and test method and I was thinking of remaking the RSS tab into an output or export tab with rss and ombi on it. What do you think?

maverick1872 commented 3 years ago

@JasonHHouse Ahh yea I have almost zero frontend JS experience. All my JS is server-side. Sorry for the late reply; I'll be home tomorrow evening and will be able to start helping then if it's still welcomed/needed.

JasonHHouse commented 3 years ago

@Maverick1872 Gotcha, I think much of the Java is written and I don't have backend JS. No worries at all. Maybe you can test it out when it's complete?

maverick1872 commented 3 years ago

@JasonHHouse Sounds good - well if you have a feature branch or something you can point me in the direction of, or the backend api stubs/docs I'll gladly take a stab at the UI implementation. Otherwise I'm happy to do a little testing if it helps out.

JasonHHouse commented 3 years ago

@Maverick1872 This is the branch I'm working on. I need to add more stubbing in for you. I can put that up later today. But if you want to take a stab at the frontend, I'd greatly appreciate it. https://github.com/JasonHHouse/gaps/tree/issue/193

maverick1872 commented 3 years ago

@JasonHHouse working on getting local env setup and working so can start testing changes. Readme doesn't seem to cover it and I'm having issues. I assumed it would be a mvn clean install but the GapsWeb project is failing on the test lifecycle. Without being able to sort this out it's going to be hard for me to get the application running locally to start figuring out how to test changes to the html.

maverick1872 commented 3 years ago

@JasonHHouse working on getting local env setup and working so can start testing changes. Readme doesn't seem to cover it and I'm having issues. I assumed it would be a mvn clean install but the GapsWeb project is failing on the test lifecycle. Without being able to sort this out it's going to be hard for me to get the application running locally to start figuring out how to test changes to the html.

The two tests failing the following per the most up-to-date changes on your branch. I've temporarily commented them out to move forward at the very least.


[ERROR]   GotifyNotificationAgentTest.sendMessage:35 Should have sent test gotify message ==> expected: <true> but was: <false>
[ERROR]   NotificationServiceTest.plexServerConnectFailed:58 Should have sent plex server connect failed message ==> expected: <true> but was: <false>```
maverick1872 commented 3 years ago

Looks like we've been discussing different things. This issue is in reference to the OMBD alternative to TMDB. Seems that you've been speaking more about the OMBI integration for requesting movies. If that is correct, I'll start taking a stab at implementing the OMBD API if that's alright.

JasonHHouse commented 3 years ago

For the short term, run with mvn clean install -DskipTests, I need to make some changes for others to build.

With regard to OMDB, go for it. I am working OMBI currently.

JasonHHouse commented 3 years ago

If you pull master and merge/rebase into your branch you'll be able to build and still run tests. I removed all the hardcoded test data and put it into a configuration file and set it up so if the config is empty, the build doesn't break.

maverick1872 commented 3 years ago

Looks like that did the trick! Back on topic though; after some deep dives yesterday I don't believe OMBD will be able to be a full replacement for TMDB at this point in time. OMBD does not contain any collection information nor do they support searching for a collection/series, so unless I'm mistaken we could only do the individual searches for movie information.

I'm assuming you want to table this story for the time being until such a point it could be a complete replacement? Thoughts?

maverick1872 commented 3 years ago

@JasonHHouse Bump

JasonHHouse commented 3 years ago

Sorry, about the delay. I think that's the correct answer. Without the collection information, we'd have to query two different sources. It could make the query go a bit faster as I have to deal with a timeout from TMDB but with automatic runs and Plex now giving far more information about ids I can mostly skip the 'search/find' calls and focus on just collection calls. Which again, removes the value of OMDB currently.

Let's table it for now.

maverick1872 commented 3 years ago

Sounds good - I'd suggest adding a label this issue to make that decision apparent. I have opened an issue on the OMDB API bug tracking repo. That being said it does not appear to be active. My understanding is that project scrapes datawiki for it's data so there may be potential to just skip OMDB and go to their source data directly.