search

JasonLG1979 / gnome-shell-extension-mpris-indicator-button

A full featured MPRIS indicator button extension for GNOME Shell 3.38+
https://extensions.gnome.org/extension/1379/mpris-indicator-button/
GNU General Public License v3.0
159 stars 21 forks source link

Extra / non-standard padding around icon #29

Closed hackel closed 4 years ago

hackel commented 4 years ago

Describe the bug

I noticed that the icon looks a ever so slightly out of place next to my other indicators. After taking screenshots to measure, it appears to have a 52px width vs 46px for the others. I don't know if something is adding 3px of extra padding or if it's up to each extension and purely a coincidence that the others appear to be similar. (Coming from Ubuntu AppIndicators?) I would just love to see everything blend together seamlessly.

image

JasonLG1979 commented 4 years ago

The padding is the result of the 'system-status-icon' style class being used. What the padding actually is is defined by the theme. That is the "standard" way to style indicators, if there was such a thing among GNOME Shell extensions (there isn't). At least that's what 99% of indicators use that I have seen.

If by Ubuntu AppIndicators you mean https://github.com/ubuntu/gnome-shell-extension-appindicator then you need to talk to them. Looking at their code it seems that they hard code the equivalent of padding for what ever reason? If you want the padding to match they are the outlier

JasonLG1979 commented 4 years ago

For reference here is the drive menu extension If anything represents a standard for indicators I think this would be it.