search

JasonLG1979 / gnome-shell-extension-mpris-indicator-button

A full featured MPRIS indicator button extension for GNOME Shell 3.38+
https://extensions.gnome.org/extension/1379/mpris-indicator-button/
GNU General Public License v3.0
159 stars 21 forks source link

GNOME Shell 3.32 support #3

Closed pcm720 closed 5 years ago

pcm720 commented 5 years ago

This pull request addresses #2. Be aware that changes required to make this extension work on 3.32 break it for 3.30 with the following error: Extension "mprisindicatorbutton@JasonLG1979.github.io" had error: TypeError: GObject.registerClass() used with in valid base class (is PanelMenuButton)

JasonLG1979 commented 5 years ago

Be aware that changes required to make this extension work on 3.32 break it for 3.30

I'm fine with not maintaining backwards compatibility. I'm downloading a Fedora Nightly iso atm to test against. I anticipated this as they're moving to more proper(ish) classes in the Shell. I imagine this will break A LOT of other extensions as well, as PanelMenu.Button is pretty widely used...

alosarjos commented 5 years ago

Can confirm it's working on Gnome 3.32 on an Arch Linux installation.

JasonLG1979 commented 5 years ago

Yep, works fine. Thanks @pcm720.

@pcm720 In the future if you plan on regularly contributing to a project generally you would make your changes in a branch, put in the pull request then delete that branch after everything is said and done and then update your fork's master to the main projects master. Basically the idea is that you never mess with your fork's master except to update your fork's master to the main projects master unless you intend on making it a true fork of the project.

pcm720 commented 5 years ago

@JasonLG1979 Thanks for the advice, I'll keep that in mind. This change seemed too small to bother with branching, so I never even thought about that.

Thanks for the great extension, let's hope GNOME developers won't break it in 3.34 :)

JasonLG1979 commented 5 years ago

This change seemed too small to bother with branching, so I never even thought about that.

Yep, it was pretty small. It really doesn't matter to me, a pull request is a pull request as far as I'm concerned. It's for your benefit.

Thanks for the great extension, let's hope GNOME developers won't break it in 3.34 :)

Don't hold your breath,lol!!!