JasonLG1979 / gnome-shell-extension-mpris-indicator-button

A full featured MPRIS indicator button extension for GNOME Shell 3.38+
https://extensions.gnome.org/extension/1379/mpris-indicator-button/
GNU General Public License v3.0
159 stars 21 forks source link

Lollypop - Secondary Click to "Raise/Minimize Toggle" also toggles Lollypop window minimise/maximise #31

Closed djsing closed 4 years ago

djsing commented 4 years ago

Steps to reproduce

Case 1: Lollypop window is maximised. -> Secondary click on the mpris-indicator-button Expected result: mpris indicator maximises to show current song etc. Actual result: mpris indicator maximises to show current song etc. as well as minimises Lollypop window. -> Secondary click on the mpris-indicator-button Expected result: mpris indicator minimises Actual result: mpris indicator minimises as well as maximises Lollypop window.

Case 1: Lollypop window is minimised. -> Secondary click on the mpris-indicator-button Expected result: mpris indicator maximises to show current song etc. Actual result: mpris indicator maximises to show current song etc. as well as maximises Lollypop window. -> Secondary click on the mpris-indicator-button Expected result: mpris indicator minimises Actual result: mpris indicator minimises as well as minimises Lollypop window.


Nothing too major, other than this the functionality of the indicator is really good.

fdinardo commented 4 years ago

Yes I can confirm, this happen with Spotify as well. Actually, I tested with Rhythmbox, and it's the same, so I am assuming that this affects all the applications.

Basically the secondary click on the icon trigger the Maximize/minimize toggle.

Other info:

Gnome-shell version: 3.36
Distro: Arch-Linux
Mpris-indicator version: latest from gnome-extensions.

I have noticed another weird style when hovering the icon. But It's better to open another issue for that.

JasonLG1979 commented 4 years ago

Basically the secondary click on the icon trigger the Maximize/minimize toggle.

Secondary clicks on the indicator icon toggles minimize/raise. That's the intended behavior.

JasonLG1979 commented 4 years ago

As per @fdinardo this should be fixed with the latest git master and will be pushed with the rest of the 3.36 fixes once they are complete.

djsing commented 4 years ago

Thanks so much!