search

JasonLG1979 / gnome-shell-extension-mpris-indicator-button

A full featured MPRIS indicator button extension for GNOME Shell 3.38+
https://extensions.gnome.org/extension/1379/mpris-indicator-button/
GNU General Public License v3.0
159 stars 21 forks source link

Enhancement: Monochrome Icons #4

Closed omeryagmurlu closed 5 years ago

omeryagmurlu commented 5 years ago

Currently, the Spotify icon is the only outsider in my top bar by being green. Having a toggle to enable monochrome icons would fix this problem.

I've read your stance on user configurable options here, but in this case there isn't a sane default I'm afraid.

JasonLG1979 commented 5 years ago

Symbolic(Monochrome) icons are preferred by default and full color icons are only used if a symbolic icon is not available. Spotify does not ship a symbolic icon with their desktop client, that is why you see a full color icon for Spotify. If you would like a symbolic Spotify icon in the panel you can file a bug with Spotify and tell them to ship a symbolic icon with their desktop client. In the meantime you could also make a symbolic icon of your own and name it spotify-client-symbolic and put it in ~/.local/share/icons/hicolor/symbolic/apps/

omeryagmurlu commented 5 years ago

Thank you, using the given directory did the job. Thanks

JasonLG1979 commented 5 years ago

Another note about Spotify. Since Spotify's volume property is broken and always returns 0 and setting it does nothing, Spotify will not have volume controls in the extension. There's no point in showing volume controls that don't do anything.

JasonLG1979 commented 5 years ago

I have an open PR to replace the png icons in the Spotify flatpak with svg's (svg's scale much better than png's and it means only one icon file per icon as opposed to a seperate file for each size) which includes a symbolic icon. So if you're a Spotify flatpak user soon you won't need to carry around your own symbolic icon. It should just work as expected in both the app menu and this extension.