JasonLG1979 / gnome-shell-extension-mpris-indicator-button

A full featured MPRIS indicator button extension for GNOME Shell 3.38+
https://extensions.gnome.org/extension/1379/mpris-indicator-button/
GNU General Public License v3.0
159 stars 21 forks source link

Possible to disable all artwork? #45

Closed Scotty-Trees closed 3 years ago

Scotty-Trees commented 3 years ago

I know this kind of seems like an odd request, but on Pop!_OS 20.04, using some .deb and some flatpak apps, most do not display the album artwork. I'm actually starting to like just seeing the applications icon in the drop down menu of this extension instead of the artwork. It's simple, it's clean, and it's consistent, and all my application icons load just fine, nothing to fuss about. So I was wondering if it's possible to add like an *exclude artwork parameter or something? I notice the extension doesn't have any settings so it comes as is, so if it's possible then, would you be able to tell me if this is at all possible to do, aka hide/don't show artwork? Is there maybe a .json file or something where I could add or remove a line to achieve this? Don't know if this is at all possible, but I figured it couldn't hurt to ask since none of my apps want to play nice lol. Btw, here's a screenshot below to show most apps doesn't show artwork, so if I could disable artwork or prevent it from showing to only show just the application icon, that would be awesome! Thanks for taking the time to read this comment.

Screenshot from 2020-10-09 03-12-33

JasonLG1979 commented 3 years ago

Nope sorry no config settings. You could add this.hide(); after this line

So it looks like this:


    _init() {
        super._init({
            style_class: 'popup-menu-icon',
            accessible_role: Atk.Role.ICON
        });
        this._useFallback = true;
        this._fingerPrint = '';
        this._coverArtIOHandler = CoverArtIOHandler.singleton;
        this._coverCallback = this._setCoverGicon.bind(this);
        this._fallback_gicon = Gio.ThemedIcon.new('audio-x-generic-symbolic');
        this.gicon = this._fallback_gicon;
        this._signals = [];
        this.pushSignal(this, 'destroy', this._onDestroy.bind(this));
        this.hide();
    }

That might do it?

JasonLG1979 commented 3 years ago

You need to talk to the pop os people and tell them to fix their bug.

Scotty-Trees commented 3 years ago

Thanks for the reply! I tried the method above. It removes any hint of artwork/album art. But it also removes the application icon as well, which I was hoping to keep, if that's possible to show? Here's how it currently looks with your fix mentioned above for reference below. If you've got other things to take care of I understand man, I know this is a super small niche thing I'm asking for.

Edit: I use Tauon Music Box (flatpak aka "com.github.taiko2k.tauonmb") as my main player besides Spotify. Perhaps I could blacklist artwork from showing for Tauon specifically maybe. Also, I'll try to figure out who to tell this about over on the Pop! end of things.

Screenshot from 2020-10-09 21-37-38