search

JasonLG1979 / gnome-shell-extension-mpris-indicator-button

A full featured MPRIS indicator button extension for GNOME Shell 3.38+
https://extensions.gnome.org/extension/1379/mpris-indicator-button/
GNU General Public License v3.0
159 stars 21 forks source link

Translations #68

Closed ChrisLauinger77 closed 1 year ago

ChrisLauinger77 commented 1 year ago

I used the following guide: https://gjs.guide/extensions/development/translations.html#marking-strings-for-translation Could not test it as the extension does not work currently :(

to pack the extension with locale support run: "gnome-extensions pack --podir=../po" inside the extensions folder (mprisindicatorbutton@JasonLG1979.github.io) this will create a zip file with the locale structure

JasonLG1979 commented 1 year ago

I'm a 4 space indent guy. I know it makes no functional difference but that's my preference, I guess it's a hold over from my Python days but other than that it looks good.

JasonLG1979 commented 1 year ago

Change that and I will merge this.

It may still be a little bit before a release happens for GNOME 43 though. There's a fair amount that needs to be changed and I've yet to work up the initiative to start.

Whatever the case this next release will more than likely be breaking and non-backwards compatible with previous Shell versions.

ChrisLauinger77 commented 1 year ago

I use the prettier vs code extension. I configured it for 4 space ident as U wished. Hope it is fine now Take your time. Good things take time ...

JasonLG1979 commented 1 year ago

Looks good. Thanks!!!