JasonLG1979 / gnome-shell-extension-weather-in-the-clock

GNU General Public License v3.0
32 stars 16 forks source link

GNOME Shell 40 #15

Closed luca-viggiani closed 3 years ago

luca-viggiani commented 3 years ago

Can you make it compatible with GS 40 please?

JasonLG1979 commented 3 years ago

Sure. I'll give it a test run on Fedora 34 and make sure it works. It's probably just a matter of a version bump. If you install it manually does it work?

luca-viggiani commented 3 years ago

Honestly I haven't tried as, by reading the migrating guide, it says you need to use gtk-4 rather than gtk-3. Hopefully it's just a matter of adding the proper version to the manifest or so

JasonLG1979 commented 3 years ago

It doesn't use any GTK widgets I don't think that really matters, all gnome-shell-extension-mpris-indicator-button required to work was a version bump in the metadata.json.

JasonLG1979 commented 3 years ago

Yep. Just tested it out in Boxes on Fedora 34. All it needs is a version bump. It's still got the styling issue mentioned in #8 I haven't figured out how to fix that yet.

JasonLG1979 commented 3 years ago

I'll push an update to the extension site tomorrow.

luca-viggiani commented 3 years ago

Great thank you! #8 is something I can live with! :)

JasonLG1979 commented 3 years ago

It really should be default in the shell to have the weather info in the panel IMHO.

luca-viggiani commented 3 years ago

It really should be default in the shell to have the weather info in the panel IMHO.

agree

JasonLG1979 commented 3 years ago

I just uploaded it and the update is live now. It must have auto approved since it's just a version bump.