search

JasonLautzenheiser / trizbort

Trizbort, the Interactive Fiction Mapper
http://www.trizbort.com
Other
131 stars 35 forks source link

unconnected edge annotations disappear #387

Closed andrewschultz closed 4 years ago

andrewschultz commented 7 years ago

In the test file https://gist.github.com/andrewschultz/cba89dff0b0b721163bbe8d517e9f445 we have 3 connectors--the middle one shows s, m and e for start, middle and end text. But if we detach the connector, we see only the s, or nothing at all.

Nyun0 commented 6 years ago

I can confirm this - in #456 you can see that is the case on the bottom-right corner (map saved in v1.2.1 and opened in v1.7.1) text_wrapping

Nyun0 commented 5 years ago

The reason for this is because the vertex of the unattached end of the line has no port assigned, resulting in NPE. The fix is easy, working on it.

Nyun0 commented 5 years ago

@andrewschultz, can you check out my branch start-end-copy if that resolves the issue? f7dbb9f

Nyun0 commented 5 years ago

@JasonLautzenheiser, I think this one can be closed.

github-actions[bot] commented 4 years ago

Stale issue message

JasonLautzenheiser commented 4 years ago

This was fixed long ago, but for some reason I never closed this issue.