JasonMillward / Autorippr

Rip discs automatically using a blend of Python, MakeMKV and HandBrake
MIT License
239 stars 60 forks source link

Add docker build to Autorippr #120

Closed garthy closed 7 years ago

garthy commented 7 years ago

This adds initial support for building a Docker image with Autorippr in it.

This has not been optimised for size and could do with some tidying up but this is the first pass.

You can use it by running " docker run -ti -v /tmp:/tmp --device=/dev/sr1 autorippr --all"

Todo.

Make config options overridable by env vars? Shrink image ...

JasonMillward commented 7 years ago

Only thought would be to perhaps remove the build_makemkv/Dockerfile directory and instead rename to Dockerfile-makemkv, then docker build -f Dockerfile-makemkv

And maybe add --force-rm to docker run --rm buildmakemkv | tar xz

garthy commented 7 years ago

The reason I have a separate directory is so Docker doesn't send all the context to this build. But can make that change easily. I still have to make it more configurable and maybe reuse the install script.

JasonMillward commented 7 years ago

Are you happy for me to merge this in now or is it still in development?