JasonMillward / Autorippr

Rip discs automatically using a blend of Python, MakeMKV and HandBrake
MIT License
241 stars 60 forks source link

HandBrake did not complete successfully #50

Closed choman closed 10 years ago

choman commented 10 years ago

Just got the new code up and running, btw when's 1.6 coming out?

Anyways, after the rip.py the compress.py is returning: HandBrake did not complete successfully

Running HB .9.9

Any Ideas?

JasonMillward commented 10 years ago

Unfortunately the older scripts leave a lot to be desired when it comes to logging errors, and handbrake can fail for any number of reasons since the success checking is very vauge.

Version 1.6 is coming out shortly (This weekend). I'm happy with the code and my final task is to update the docs.

Can you wait until I've released 1.6 and try again as the new logging will provide more detail to assist in solving issues like this one.

choman commented 10 years ago

Yeah, I had to "patch" and a slight enhancement to the setup script. No worries now though.
I can wait til 1.6, looking forward to it. LMK if you want an early tester or late tester, depending on your perspective.

Also, few small requests (now or future) and I can help a) setup script to use "axel -a -o " if available over wget (that was my enhancement) b) if a makemkv license file exists in a configurable diectory, read the license file from there during setup ( that was next for me, yeah I was gonna submit them) c) add a dependency checker to the setup, I was missing the tender? stuff, then I saw the post. it would be nice if the setup script caught all of them d) ppa? for ubuntu

JasonMillward commented 10 years ago

Closing this because it's fixed in the newest version.